proxy: stop listening only on etcd error #80
Merged
+39
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
proxy_stop_listening_only_on_etcd_error
branch
from
ecccfa5
to
4b167f5
Compare
It makes more sense to stop listening only on communication problems with etcd since it's the unique case when the proxy doesn't know what it should do and shouldn't be balanced. Instead having an empty proxyConf and closing the listening socket will exclude the proxy from a balancer without any reason since its state is good.
sgotti
force-pushed
the
proxy_stop_listening_only_on_etcd_error
branch
from
4b167f5
to
0d6b285
Compare
sgotti
added a commit
that referenced
this pull request
Oct 29, 2015
…error proxy: stop listening only on etcd error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to stop listening only on communication problems with etcd
since it's the unique case when the proxy doesn't know what it should do and
shouldn't be balanced.
Instead having an empty proxyConf and closing the listening socket will exclude
the proxy from a balancer without any reason since its state is good.