Auto-Inject Version number in new Issues

[mezmi]

Installed Version: 1.0.3 DEV | Environment: Chrome/Tampermonkey

Expected Behavior

When creating an issue on GitHub, SOX should inject the currently installed version number into the post.

Actual Behavior

The version number is being injected, but only after a page refresh. I suspect a timing issue.

Related Code

var SOX_VERSION = '1.0.3 DEV';

// auto-inject version number into new GitHub issues
if (location.hostname.indexOf('github.com') > -1 ) {
    var $issue = $('#issue_body'),
        issueText = $issue.text();

    issueText = issueText.replace('1.X.X', SOX_VERSION);
    $issue.text(issueText);

    // on GitHub, stop execution of the rest of the script.
    return;
}

[shu8]

fixed

[mezmi]

@shu8

The version number is being injected, but, with that code running in a loop I am unable to type or select text from within the issue body.

The looped code should stop executing after the first successful injection of the version number.

We should also change the URL from github.com to github.com/soscripted/sox/issues/new and set a bool flag after it's ran.. What do you think?

[shu8]

@enki-code

bool-flag, yes.

but if we change the match URL to that issue link, then it will only work if you land directly onto that page (remember the issue where you needed to refresh to make it work).

[shu8]

@enki-code but it works for me... I can type and select... or do you mean somewhere else??

[mezmi]

I was just coming to update my comment on the url.. you're right, that wouldn't work. 👍 In the issue body, I cannot type or select text because every 2 seconds the text is being replaced

[shu8]

@enki-code Do you not have the return;? That should escape the setInterval..

setInterval(function() {
    if($('#issue_body').length) {
        var $issue = $('#issue_body'),
            issueText = $issue.text();
        issueText = issueText.replace('1.X.X', SOX_VERSION); //inject the SOX version by replacing the issue template's placeholder '1.X.X'
        issueText = issueText.replace('Chrome/Tampermonkey', SOX_MANAGER); //inject the SOX userscript manager+platfirm by replacing the issue template's placeholder 'Chrome/Tampermonkey'
        $issue.text(issueText);
   }
   // on GitHub, stop execution of the rest of the script.
   return;
}, 2000);

[shu8]

Issue seems to have been random and neither of us can reproduce. Closing again...

[mezmi]

It was a glitch in the Matrix.