Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Get access token?' link broken #50

Closed
rjrudman opened this issue Apr 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@rjrudman
Copy link

commented Apr 10, 2016

Installed Version: v1.0.3 | Environment: Chrome/Tampermonkey Version 49.0.2623.110 m

Expected Behavior

Link should work on all stack exchange sites, or guide the user to meta.stackexchange.com to get their access token

Actual Behavior

Clicking a link while not on http://meta.stackexchange.com/ throws an error.

Error Logs

VM2649:3464 Uncaught channelUrl must be under the current domain
r@ VM2649:3464
(anonymous function) @ VM2649:3740
n.event.dispatch @ VM2649:8
r.handle @ VM2649:8

Steps to reproduce

Visit http://stackoverflow.com/
Open up the settings
Click on 'Get access token?'

@shu8

This comment has been minimized.

Copy link
Member

commented Apr 10, 2016

@rjrudman thanks for posting here! I think I have a fix ready, just testing and then I'll push :)

@shu8 shu8 added the bug label Apr 10, 2016

@shu8 shu8 added this to the v1.0.4 milestone Apr 10, 2016

@shu8 shu8 self-assigned this Apr 10, 2016

shu8 added a commit that referenced this issue Apr 10, 2016

shu8 added a commit that referenced this issue Apr 10, 2016

@shu8

This comment has been minimized.

Copy link
Member

commented Apr 10, 2016

@rjrudman ok, it's fixed :)

Please could you install 1.0.4 DEV and confirm this is now working for you?


if you're interested...: :)

When registering an app on Stack Apps, you have to give an Oauth Domain, which has to be a single site, so I've made it check for which site you're on and compare it to the current site. If you're not on the given Oauth Domain site, it alert's you that you need to be, otherwise it works as normal :)

Thanks again for the bug report!

@rjrudman

This comment has been minimized.

Copy link
Author

commented Apr 10, 2016

Yep - works perfectly, thanks! :)

@shu8 shu8 closed this Apr 10, 2016

@shu8 shu8 removed the ready label Apr 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.