Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PEM formatted RSA keys for ssh server #10

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Create PEM formatted RSA keys for ssh server #10

merged 3 commits into from
Oct 8, 2018

Conversation

waveletlet
Copy link
Contributor

Fix for #9

@waveletlet waveletlet changed the title Specify PEM output in call to 'ssh-keygen' Create PEM formatted RSA keys for ssh server Sep 15, 2018
@waveletlet
Copy link
Contributor Author

Replaced call to ssh-keygen with key generation using go stdlibs.

sosedoff
sosedoff reviewed Sep 17, 2018
View reviewed changes
Copy link
Owner

@sosedoff sosedoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, i added a few notes regarding some debug stuff

ssh.go Outdated
return nil

privateKeyFile, err := os.Create(s.config.KeyPath())
fmt.Println(err)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this debug statement

ssh.go Show resolved Hide resolved
ssh.go Outdated
}

pubKeyPath := s.config.KeyPath() + ".pub"
fmt.Println(pubKeyPath)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debug statement

@sosedoff
Copy link
Owner

sosedoff commented Oct 3, 2018

@waveletlet ping

@waveletlet
Copy link
Contributor Author

Ok, fixed the issues you mentioned.

@sosedoff sosedoff merged commit d2ad9c4 into sosedoff:master Oct 8, 2018
@waveletlet waveletlet deleted the fix-server-keygen branch October 13, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosedoff sosedoff sosedoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waveletlet @sosedoff