Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conntrackd] Support Debian/Ubuntu and capture conntrack info #2049

Closed
hillpd opened this issue May 6, 2020 · 6 comments
Closed

[conntrackd] Support Debian/Ubuntu and capture conntrack info #2049

hillpd opened this issue May 6, 2020 · 6 comments

Comments

@hillpd
Copy link
Contributor

hillpd commented May 6, 2020

The plug-in checks for "conntrack-tools" but doesn't capture any debug information from the conntrack utility. On Debian/Ubuntu the tools package is simply named "conntrack" which should be included.

Recommend adding the following command output:
conntrack -L -o extended
conntrack -S

@ddstreet
Copy link
Contributor

ddstreet commented May 6, 2020

@slashdd @BryanQuigley

@jay-vosburgh
Copy link

"conntrack" is a separate package (on Ubuntu), so perhaps the cleanest way forward is to add a plugin for conntrack itself, and capture -L, -S, etc, via the separate plugin.

@BryanQuigley
Copy link
Contributor

@TurboTurtle I'm thinking just add to current plugin makes sense. It could also be separated as two plugins conntract and contractd (On ubuntu conntract is supported, while conntractd is not).

@TurboTurtle
Copy link
Member

Wow, this excerpt from the manual really hits the nail on the head

Although the name of both tools is very similar - and you can blame me for that, I'm not a marketing guy - they are used for very different tasks.

At any rate, since both utilities are at least logically coupled together I'd be in favor of adding this to the current plugin, rather than splitting out a new one.

@slashdd
Copy link

slashdd commented May 11, 2020

sosreport is fault tolerant (if cmd doesn't exist, it will continue) so I personally would simply add the conntrack command in the current plugin with the conntrack package name as one of the possible triggers. And maybe rename the plugin from conntrackd.py to conntrack.py to make it more connection tracking specifics ?

@pmoravec
Copy link
Contributor

+1 to have just one plugin, and rename it to contrack.

hemanthnakkina-zz pushed a commit to hemanthnakkina-zz/sos that referenced this issue Sep 27, 2020
The plugin conntrackd is renamed to conntrack. Added the following
conntrack commands to the plugin.
conntrack -L -o extended
conntrack -S

Closes: sosreport#2049

Signed-off-by: Hemanth Nakkina hemanth.nakkina@canonical.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants