Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] sos.help is ignored at package build time #2860

Closed
slashdd opened this issue Feb 16, 2022 · 1 comment
Closed

[4.3] sos.help is ignored at package build time #2860

slashdd opened this issue Feb 16, 2022 · 1 comment

Comments

@slashdd
Copy link

slashdd commented Feb 16, 2022

It's causing runtime issue once sos 4.3 is built (DEB package here) due to lack of sos.help module presence.

$ sos report 
Traceback (most recent call last):
  File "/usr/bin/sos", line 21, in <module>
    sos = SoS(sys.argv[1:])
  File "/usr/lib/python3/dist-packages/sos/__init__.py", line 62, in __init__
    import sos.help
ModuleNotFoundError: No module named 'sos.help'

Adding the following before the build process fixes the issue by including sos.help in the mix:

setup.py

     packages=[
-        'sos', 'sos.presets', 'sos.presets.redhat', 'sos.policies',
+        'sos', 'sos.help', 'sos.presets', 'sos.presets.redhat', 'sos.policies',
@slashdd slashdd changed the title [4.3 [4.3] help is ignored at package time Feb 16, 2022
@slashdd slashdd changed the title [4.3] help is ignored at package time [4.3] help is ignored at package build time Feb 16, 2022
@slashdd slashdd changed the title [4.3] help is ignored at package build time [4.3] sos.help is ignored at package build time Feb 16, 2022
pmoravec added a commit to pmoravec/sos that referenced this issue Feb 16, 2022
Related to sosreport#2860

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
pmoravec added a commit to pmoravec/sos that referenced this issue Feb 16, 2022
Resolves: sosreport#2860
Closes: sosreport#2861

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec
Copy link
Contributor

Good catch, #2861 should fix that (and also two other relevant bits).

TurboTurtle pushed a commit that referenced this issue Feb 16, 2022
Related to #2860

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants