Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] all cleaner tests to have --no-update option #3254

Open
pmoravec opened this issue May 26, 2023 · 2 comments · May be fixed by #3286
Open

[tests] all cleaner tests to have --no-update option #3254

pmoravec opened this issue May 26, 2023 · 2 comments · May be fixed by #3286

Comments

@pmoravec
Copy link
Contributor

When running independent tests one after another, some sos cleaner can update /etc/sos/cleaner/default_mapping by unexpected value which can break further avocado tests.

Any sos clean test in avocado must have --no-update option to prevent the default_mapping update.
@TurboTurtle
Copy link
Member

I'd be ok with this, if we add a test that does not include --no-update so that we can ensure that we're writing default_mapping appropriately.

@pmoravec
Copy link
Contributor Author

Such a test makes sense; maybe worth backing the mapping file prior such test and restoring the original afterwards, just to be sure.

dtzhou2 pushed a commit to dtzhou2/sos that referenced this issue Jun 22, 2023
[avocado_tests] added default_mapping test
e51a109 
Added default mapping test and made it so all cleaner tests have the --no-update option as in issue sosreport#3254
@dtzhou2 dtzhou2 linked a pull request Jun 22, 2023 that will close this issue
Open
1 task
dtzhou2 pushed a commit to dtzhou2/sos that referenced this issue Jun 26, 2023
[avocado_tests] added default_mapping test
87e9fd0 
Added default mapping test and made it so all cleaner tests have the --no-update option as in issue sosreport#3254
dtzhou2 pushed a commit to dtzhou2/sos that referenced this issue Jul 3, 2023
[avocado_tests] added default_mapping test
f816b8f 
Added default mapping test and made it so all cleaner tests have the --no-update option as in issue sosreport#3254

Signed-off-by: Daniel Zhou <dzhou@redhat.com>
dtzhou2 pushed a commit to dtzhou2/sos that referenced this issue Jul 3, 2023
Update report_with_mask.py
14995ba 
[avocado_tests] added default_mapping test

Added default mapping test and made it so all cleaner tests have the --no-update option as in issue sosreport#3254

Signed-off-by: Daniel Zhou <dzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[avocado_tests] added default_mapping test dtzhou2/sos
2 participants
@TurboTurtle @pmoravec