There are no plugin to gater K8s/OCP rotated logs #3677
Comments
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 17, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes a new plugin called `pod_log`, similar to the xisting `container_log`, that can retrieve rotated logs for the containers. The plugin will not only download the `/var/log/pods` files but also the `/var/log/container` symlinks. The plugin doesn't use the `all_logs` flag, since the usage of the plugin assumes the intent of getting rotated logs, otherwise the `container_log` plugin can be used. An alternative would be to extend the existing `container_log` plugin to also retrieve rotated container logs. This approach has been discarded because we would either have to modify existing behavior for the `all_logs` flag (breaking backward compatibility) or add a new parser arguments just to tell it to also gather rotated logs (not reasonable). Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 17, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes a new plugin called `pod_log`, similar to the xisting `container_log`, that can retrieve rotated logs for the containers. The plugin will not only download the `/var/log/pods` files but also the `/var/log/container` symlinks. The plugin doesn't use the `all_logs` flag, since the usage of the plugin assumes the intent of getting rotated logs, otherwise the `container_log` plugin can be used. An alternative would be to extend the existing `container_log` plugin to also retrieve rotated container logs. This approach has been discarded because we would either have to modify existing behavior for the `all_logs` flag (breaking backward compatibility) or add a new parser arguments just to tell it to also gather rotated logs (not reasonable). Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 17, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes a new plugin called `pod_log`, similar to the xisting `container_log`, that can retrieve rotated logs for the containers. The plugin will not only download the `/var/log/pods` files but also the `/var/log/container` symlinks. The plugin doesn't use the `all_logs` flag, since the usage of the plugin assumes the intent of getting rotated logs, otherwise the `container_log` plugin can be used. An alternative would be to extend the existing `container_log` plugin to also retrieve rotated container logs. This approach has been discarded because we would either have to modify existing behavior for the `all_logs` flag (breaking backward compatibility) or add a new parser arguments just to tell it to also gather rotated logs (not reasonable). Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 20, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes extending the `container_log` to make it also capable of retrieving logs from `var/log/pods` using a plugin boolean option called `rotated`. When retrieving the pods directory, all logs will be retrieved from it regardless of size, as it is implicit that the intent is to get all rotated logs. Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 20, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes extending the `container_log` to make it also capable of retrieving logs from `var/log/pods` using a plugin boolean option called `rotated`. When retrieving the pods directory, all logs will be retrieved from it regardless of size, as it is implicit that the intent is to get all rotated logs. Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 20, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes extending the `container_log` to make it also capable of retrieving logs from `var/log/pods` using a plugin boolean option called `rotated`. When retrieving the pods directory, all logs will be retrieved from it regardless of size, as it is implicit that the intent is to get all rotated logs. This patch also adds the `maxage` option to the `container_log` plugin, allowing the retrieval of logs that are not older than `maxage` hours. This affects bot the normal containers log gathering as well as the pods gathering. Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 21, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes extending the `container_log` plugin to make it also capable of retrieving rotated logs from `var/log/pods` using a plugin boolean option called `rotated`. Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Akrog
added a commit
to Akrog/sos
that referenced
this issue
Jun 24, 2024
In Kubernetes/OpenShift rotated logs have no symbolic link in /var/log/containers and they cannot be retrieved using `oc logs` either, so there is no way to get these rotated logs in a SOS report. This patch proposes extending the `container_log` plugin to make it also capable of retrieving rotated logs from `var/log/pods` using a plugin boolean option called `rotated`. Closes sosreport#3677 Signed-off-by: Gorka Eguileor <geguileo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Kubernetes/OpenShift nodes when the logs are rotated there is no way to get them in an sos report.
It is true than in most cases there is a centralized log solution, but in some other it is convenient to be able to get these logs.
All rotated logs are present under
/var/log/podswhich cannot be retrieved any way:container_logsplugin, since it only gathers the logs symlinked in/var/log/containersopenshiftplugin, as it is only able to get the current logs usingoc logs.The text was updated successfully, but these errors were encountered: