Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean] Properly obfuscate MAC addresses #3302

Merged

Conversation

jjansky1
Copy link
Contributor

Some of mac addresses was not properly obfuscated because some collected data contains mac addresses in format 01: and parser was not ready for that.

Also added mapper which will obfuscate mac address in case it is in format with _ instead of : as for example

00_50_56_87_5d_01

instead of

00:50:56:87:5d:01

Format with _ is used for example by vmware plugin.

Resolves: #3302


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Some of mac addresses was not properly obfuscated because
some collected data contains mac addresses in format
01:<mac> and parser was not ready for that.

Also added mapper which will obfuscate mac address in case
it is in format with _ instead of : as for example

00_50_56_87_5d_01

instead of

00:50:56:87:5d:01

Format with _ is used for example by vmware plugin.

Resolves: sosreport#3302

Signed-off-by: Jan Jansky <jjansky@redhat.com>
@jcastill
Copy link
Member

LGTM.
About the two failed rpm tests, I had the same issue with my last PR and I think @pmoravec restarted them and they worked the second time, iIrc.

@jjansky1
Copy link
Contributor Author

LGTM. About the two failed rpm tests, I had the same issue with my last PR and I think @pmoravec restarted them and they worked the second time, iIrc.

ack

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3302
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jjansky1
Copy link
Contributor Author

We are waiting on this PR to be able to make viable build, can we someone speed up merge or not merge? If we can somehow force rebuild of "/etc/sos/cleaner/default_mapping" that i am not sure about it may be useful for this PR.

@TurboTurtle TurboTurtle merged commit 59c2660 into sosreport:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants