-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pebble][init] Add pebble service manager #3453
Conversation
09ef47f
to
f9e6c50
Compare
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
f9e6c50
to
62fc30c
Compare
Closes: sosreport#3207 Resolves: SET-86 Signed-off-by: Arif Ali <arif.ali@canonical.com>
62fc30c
to
fce0cae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on its own (just the CodeQL note) - where do we anticipate this being used? Do we need to link up any existing policies to it now or is this prep work for something coming later?
'config': config, | ||
} | ||
except IndexError: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep CodeQL happy, let's add a comment here explaining either how we got to this exception (header/foooter output?) or some similar note to future-us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, it was a copy-paste from the systemd one. So, I think we ought to fix tat one too ;)
Closes: #3207
Resolves: SET-86
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines