Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Drop obsolete TestCase.assertEquals() #3467

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[tests] Drop obsolete TestCase.assertEquals() #3467

merged 1 commit into from
Jan 11, 2024

Conversation

martinpitt
Copy link

@martinpitt martinpitt commented Jan 10, 2024

unittest.TestCase.assertEquals() was deprecated in Python 3 [1], and finally dropped in Python 3.12. This now causes the unit tests to fail [2].

[1] https://docs.python.org/3.5/library/unittest.html#deprecated-aliases
[2] https://bugs.debian.org/1058214


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

`unittest.TestCase.assertEquals()` was deprecated in Python 3 [1], and
finally dropped in Python 3.12. This now causes the unit tests to fail [2].

[1] https://docs.python.org/3.5/library/unittest.html#deprecated-aliases
[2] https://bugs.debian.org/1058214

Signed-off-by: Martin Pitt <mpitt@debian.org>
@martinpitt
Copy link
Author

I was wondering why you didn't notice that long ago already -- but it seems neither "breakage test python latest" nor the RPM builds don't actually run the unit tests. I suggest to enable them in both places.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3467
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle
Copy link
Member

I was wondering why you didn't notice that long ago already -- but it seems neither "breakage test python latest" nor the RPM builds don't actually run the unit tests. I suggest to enable them in both places.

The unit tests are run in our "Stage One" jobs. The "breakage" test is literally just "do we fall flat on our face when execting with newer python versions?"

In any event, LGTM.

@TurboTurtle TurboTurtle merged commit 769768a into sosreport:main Jan 11, 2024
35 checks passed
@martinpitt martinpitt deleted the assertEquals branch January 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants