Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sign-off check in the workflow #3547

Closed
wants to merge 1 commit into from

Conversation

pponnuvel
Copy link
Contributor


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3547
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pponnuvel pponnuvel force-pushed the sign_off_workflow branch 6 times, most recently from bb54c92 to 0913867 Compare March 3, 2024 10:15
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
@pponnuvel
Copy link
Contributor Author

  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment"

Looks like a permission issue.

@TurboTurtle
Copy link
Member

We already have the sign-off check provided by the DCO app enabled.

I left the check box on the GH template in place as a visual reminder for contributors before opening a PR, but I'm not married to keeping it.

@pponnuvel
Copy link
Contributor Author

Ah, that's fine then.

@pponnuvel pponnuvel closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants