-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhc] Collect information related to rhc-worker-playbook #3584
[rhc] Collect information related to rhc-worker-playbook #3584
Conversation
I tried to reduce the number of regexp groups from 5 but I cannot think of anyway to reduce more. Any ideas? |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/rhc.py
Outdated
# "ansible_ssh_host_key_ecdsa_public": ********, | ||
|
||
path = "/var/log/rhc-worker-playbook/ansible/*" | ||
regexp = r"(\s*\"ansible_ssh_host_key_)(.+)(_public\":\s*)(.+)(\,)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a tiny probability some SSH public key will be the last item in the JSON map, hence without trailing comma. So (\,)
should be (\,|$)
I guess..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good point, I'll modify that group and test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Capture information from rhc worker playbooks, and obfuscate public ssh keys. Related: RH: RHEL-27555 Signed-off-by: Jose Castillo <jcastillo@redhat.com>
5c7d19a
to
aa3f11b
Compare
Capture information from rhc worker playbooks, and obfuscate public ssh keys.
Related: RH: RHEL-27555
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines