Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Refactor pylint configuration #3644

Merged
merged 1 commit into from
May 23, 2024

Conversation

arif-ali
Copy link
Member

Also fix tox issues with posargs and further fine tuning


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Also fix tox issues with posargs and further fine tuning

Signed-off-by: Arif Ali <arif.ali@canonical.com>
@arif-ali
Copy link
Member Author

The refactor of the pylint is done in this way to ensure that we enable
everything and only disable what we think we should disable. This was after some
discussions with one of our Engineering leads and was their main advice.

The disable section of the pylintrc is ordered in a way that the less amount
of work to accomplish is near the bottom. This also helps, if anyone wants to
contribute, and hence can work on a pylint module one at a time. I have grouped
the modules in 2, the top, that I think we should disable anyway and the bottom
section that we ought to fix. We may decide that some of these we can ignore.

I am hoping this will help with improved code and consistency across the board.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3644
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle merged commit e89ccce into sosreport:main May 23, 2024
39 checks passed
@arif-ali arif-ali deleted the sos-arif-pylint-refactor branch October 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants