Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openstack_edpm] Add additional paths #3650

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

slagle
Copy link
Contributor

@slagle slagle commented May 28, 2024

These paths are also used by EDPM and should be collected by the plugin.

Signed-off-by: James Slagle jslagle@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

sos/report/plugins/openstack_edpm.py Outdated Show resolved Hide resolved
sos/report/plugins/openstack_edpm.py Outdated Show resolved Hide resolved
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3650
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

'/etc/os-net-config/',
'/var/lib/config-data/',
'/var/lib/edpm-config/',
'/var/log/containers/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nack to /var/log/containers as a whole. There are tons of components that drop logs there these days.

The container_log plugin capture this as needed, but if you need specific containers call them out explicitly in these paths, e.g. /var/log/containers/$container/$log which is what many of the other openstack plugins do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped /var/log/containers

These paths are also used by EDPM and should be collected by the plugin.

Signed-off-by: James Slagle <jslagle@redhat.com>
@TurboTurtle TurboTurtle merged commit 6522adc into sosreport:main May 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants