-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packit|cirrus] Remove centos-stream-8 references #3652
[packit|cirrus] Remove centos-stream-8 references #3652
Conversation
Remove packit and cirrus references to centos-stream 8 that's EOL since May 31st 2024. Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Just thinking from the outside, and no experience with foreman at all. Is it worth doing the tests for foreman on centos9 stream instead and the versions being removed, or does it not make sense? |
Good point. I thought it was related to CentOS 8 only, but I haven't found any info regarding that yet. Hopefully Pavel should be able to shed some light |
Foreman is supported on CentOS Stream 8 and 9 (https://www.theforeman.org/manuals/3.10/quickstart_guide.html) while the downstream product Satellite is supported on RHEL8 only (so far). For those "legacy" reasons, I would suggest to:
Like:
|
Thank you @pmoravec . I'll rewrite this and push again |
you're still going to have issues with the yum repos right? and will need to point to vault.centos.org? We could do the same for the other CI bits, if we're going to keep it for foreman |
Indeed, the EOS of CentOS Stream 8 breaks a lot (for us). We are figuring out how to proceed with some testing for foreman. As any PR will fail on the CI tests for CentOS Stream 8 now, I would suggest merging this PR as is as a kind of "hotfix" to prevent false negatives. And open a new issue where we will propose some more stable plan. Does this make sense or do you see a better approach? |
I think that makes sense, let's create a new GH issue, and then we can track it, and resolve it long-term, if there is a resoluton. I think, what you could do, update the setup section, detect that if it is centos 8, and then update the dnf/yum repos to point to vault? I think that could work; as the setup bit is the common bits across all the CI bits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on previous comment, happy for this to go through, but lets create a new issue.
however, if it's a quick fix/turnaround, then we can continue in this PR
Remove packit and cirrus references to centos-stream 8 that's EOL since May 31st 2024.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines