Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packit|cirrus] Remove centos-stream-8 references #3652

Merged

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Jun 3, 2024

Remove packit and cirrus references to centos-stream 8 that's EOL since May 31st 2024.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Remove packit and cirrus references to centos-stream 8
that's EOL since May 31st 2024.

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
@jcastill
Copy link
Member Author

jcastill commented Jun 3, 2024

First time doing this, so hopefully I didn't miss anything. This is related to the errors that @arif-ali got in #3648 . CentOS Stream 8 was EOL'ed on May 31st 2024.
@pmoravec , thoughts?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3652
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Jun 3, 2024

Just thinking from the outside, and no experience with foreman at all.

Is it worth doing the tests for foreman on centos9 stream instead and the versions being removed, or does it not make sense?

@jcastill
Copy link
Member Author

jcastill commented Jun 3, 2024

Good point. I thought it was related to CentOS 8 only, but I haven't found any info regarding that yet. Hopefully Pavel should be able to shed some light

@pmoravec
Copy link
Contributor

pmoravec commented Jun 4, 2024

Foreman is supported on CentOS Stream 8 and 9 (https://www.theforeman.org/manuals/3.10/quickstart_guide.html) while the downstream product Satellite is supported on RHEL8 only (so far). For those "legacy" reasons, I would suggest to:

  • still keep CentOS Stream 8 just for foreman testing, for some time
  • have foreman tested also on CentOS 9
  • bump the foreman version from 3.3/3.5/3.7 to e.g. 3.9/3.10 (worth doing in either case as foreman evolved)

Like:

    matrix:
        - env:
            <<: *centos8
            FOREMAN_VER: "3.9"
        - env:
            <<: *centos9
            FOREMAN_VER: "3.10"
        - env:
            PROJECT: ${DEBIAN_PROJECT}
            VM_IMAGE_NAME: ${DEBIAN_IMAGE_NAME}
            BUILD_NAME: ${DEBIAN_NAME}
            FOREMAN_VER: "3.10"

@jcastill
Copy link
Member Author

jcastill commented Jun 4, 2024

Thank you @pmoravec . I'll rewrite this and push again

@arif-ali
Copy link
Member

arif-ali commented Jun 4, 2024

you're still going to have issues with the yum repos right? and will need to point to vault.centos.org? We could do the same for the other CI bits, if we're going to keep it for foreman

@pmoravec
Copy link
Contributor

pmoravec commented Jun 4, 2024

Indeed, the EOS of CentOS Stream 8 breaks a lot (for us). We are figuring out how to proceed with some testing for foreman.

As any PR will fail on the CI tests for CentOS Stream 8 now, I would suggest merging this PR as is as a kind of "hotfix" to prevent false negatives. And open a new issue where we will propose some more stable plan.

Does this make sense or do you see a better approach?

@arif-ali
Copy link
Member

arif-ali commented Jun 4, 2024

I think that makes sense, let's create a new GH issue, and then we can track it, and resolve it long-term, if there is a resoluton.

I think, what you could do, update the setup section, detect that if it is centos 8, and then update the dnf/yum repos to point to vault? I think that could work; as the setup bit is the common bits across all the CI bits

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on previous comment, happy for this to go through, but lets create a new issue.

however, if it's a quick fix/turnaround, then we can continue in this PR

@arif-ali arif-ali merged commit ae13d0f into sosreport:main Jun 4, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants