-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fail2ban] Add new plugin for fail2ban #3685
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a couple suggestions.
Just doubling check, any config files we are collecting here, any passwords that needs obfuscating? Also the trail line is still there, in the recent push |
There should not be any passwords, but the |
overall, looks good to me, before we can merge this, we need the commits to be squashed, so that we have one commit for the PR. Once you do that we can move this one forward |
New plugin for fail2ban daemon. Signed-off-by: Jake Nabasny <jake.nabasny@canonical.com>
Nothing sensitive should be in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
New plugin for fail2ban daemon.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines