Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SparrowMahjong] Transpose observation (15 x 11 to 11 x 15) #1010

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sotetsuk
Copy link
Owner

Align to channel-last like other environments (e.g., 3 x 3 x 2 in Tic-tac-toe).
In SparrwoMahjong, 11 tiles must corresponds to board (e.g., 3 x 3)

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1010 (737c40e) into main (29e6ab0) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files          53       53           
  Lines        5897     5897           
=======================================
  Hits         5075     5075           
  Misses        822      822           
Files Changed Coverage Δ
pgx/sparrow_mahjong.py 95.75% <50.00%> (ø)

@sotetsuk sotetsuk merged commit 75abefe into main Aug 21, 2023
5 of 6 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/feat/sm-transpose branch August 21, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant