-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dataclass] Fix dataclass mutable defaults error #1067
Conversation
Thank you for sending the PR! I've confirmed that it works with 3.11. Also, Support for 3.11 is not a high priority for us, so while this PR is a promising solution, we haven't yet settled on a single solution. Therefore, we'd like to put this PR on hold for now. import jax
import jax.numpy as jnp
import pgx
env = pgx.make("tic_tac_toe")
print(jax.make_jaxpr(env.init)(jax.random.PRNGKey(0))) Python3.9.18 + Pgx v1.4.0: 57 lines
Python3.11.6 + #1067: 75 lines
Both on M1 mac |
I found that the above inspections are wrong and this PR does not change the complexity of jaxpr. Python 3.9.16 @ 8764592 (latest)
Python 3.11.6 @ this PR
|
Codecov Report
@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 86.90% 86.92% +0.02%
==========================================
Files 54 54
Lines 6047 6052 +5
==========================================
+ Hits 5255 5261 +6
+ Misses 792 791 -1
|
#1062