AWSClient.send() functions don't throw errors so don't mark them as if they do #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 64.82% 64.82%
=======================================
Files 36 36
Lines 6254 6254
=======================================
Hits 4054 4054
Misses 2200 2200
Continue to review full report at Codecov.
|
Yasumoto
reviewed
Sep 13, 2019
| @@ -151,7 +151,7 @@ extension AWSClient { | |||
| } | |||
| } | |||
|
|
|||
| public func send<Output: AWSShape>(operation operationName: String, path: String, httpMethod: String) throws -> Future<Output> { | |||
| public func send<Output: AWSShape>(operation operationName: String, path: String, httpMethod: String) -> Future<Output> { | |||
|
|
|||
| return signer.manageCredential().thenThrowing { _ in | |||
There was a problem hiding this comment.
Great save! thenThrowing, renamed to flatMapThrowing in NIO2, does not throw, but returns a failed future on error 🎉
Yasumoto
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify using the library a little