This repository has been archived by the owner on Dec 26, 2019. It is now read-only.
Failure on second redirect #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the bug was there for ages. Thanks a lot @rossjourdain! 😄👍 |
|
No worries - bit of an edge case... Thanks for the gem @soulim |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an edge case that struck today. If you request an oembed URL that results in a redirect, that results in a redirect, you get an error.
It happens on 'fetch' because http.rb:21, thinks it has an options hash but it has been passed a fixnum by http.rb:39.
Hope that makes sense!