Rework soundInfo,releaseInfo functions to work with contractAddress and editionId #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0aea32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PabloSzx
changed the title
gigamesh
reviewed
Sep 2, 2022
| query ReleaseInfo($releaseId: UUID!) { | ||
| release: release(id: $releaseId) { | ||
| query ReleaseInfo($contractAddress: Address!, $editionId: String) { | ||
| release: releaseContract(contractAddress: $contractAddress, editionId: $editionId) { |
There was a problem hiding this comment.
I take it we're including editionId so clients can look up info about V1 protocol contracts?
There was a problem hiding this comment.
And when the album releases are separated within the same contract
gigamesh
approved these changes
Sep 2, 2022
PabloSzx
force-pushed
the
pabloszx/release-query
branch
from
5d4c391
to
d0aea32
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.