Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundEditionType: single | album #62

Merged
merged 8 commits into from
Sep 10, 2022
Merged

Conversation

gigamesh
Copy link
Contributor

@gigamesh gigamesh commented Sep 9, 2022

Upgrades to protocol version with SoundCreatorV1 album address & introduces EditionType to distinguish between the 'SINGLE' & 'ALBUM' creator address. The type is an optional param to functions, and we default to single.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

🦋 Changeset detected

Latest commit: 481fab7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@soundxyz/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@PabloSzx PabloSzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@PabloSzx PabloSzx merged commit 5696974 into main Sep 10, 2022
@PabloSzx PabloSzx deleted the gigamesh/soundEditionType branch September 10, 2022 19:11
@github-actions github-actions bot mentioned this pull request Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants