-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support self-hosted/custom git providers #138
Conversation
🦋 Changeset detectedLatest commit: 598d3af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@noxify is attempting to deploy a commit to the souporserious Team on Vercel. A member of the Team first needs to authorize it. |
Updated the Reason why I did this change: While creating the unit tests I got some errors with the expected vs. received url. Also updated the input for the Let me know that you think about these changes @souporserious. |
Based on the amount of arguments for Example // old
getGitFileUrl({
'/directory-name/file-name',
undefined,
undefined,
'https://self-hosted.git.company.tld/owner-name/repo-name',
undefined,
'bitbucket'
})
// new
getGitFileUrl({
filePath: '/directory-name/file-name',
gitSource: 'https://self-hosted.git.company.tld/owner-name/repo-name',
gitProvider: 'bitbucket'
}) |
Updated the relevant parts and added also a new example. But while running
I get the same error - Added temporary some debug prints and it seems that the I assumed that Any idea how to solve this ? |
Ok, got it - added the |
Ok - for me it looks good, if I have missed something, please let me know.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great 🎉 thank you for adding tests!
Previously only
github.com
,gitlab.com
andbitbucket.org
were supported as git provider.This merge request adds the functionality to set the git provider manually.
fixes #137