Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CAS auth strategy #2246

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Add support for CAS auth strategy #2246

merged 12 commits into from
Nov 30, 2023

Conversation

chownces
Copy link
Contributor

@chownces chownces commented Oct 30, 2022

Description

Opening a draft PR for CAS authentication to support the teaching team at UU in the interim. Currently, the frontend only supports the OAuth2 specification.

Im planning to do a proper follow up sometime in Dec '22 before merging this. Or whoever is interested in taking this up, please feel free to let me know too 🙂:

  • proper handling of the URL parameters depending on which auth provider type is being used
  • add test cases

Corresponding backend PR: source-academy/backend#916

Type of change

  • New feature (non-breaking change which adds functionality)

How to test

TBC

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Oct 30, 2022

Pull Request Test Coverage Report for Build 5290931377

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 17 (52.94%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 36.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/utils/Constants.ts 6 9 66.67%
src/commons/utils/AuthHelper.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/utils/AuthHelper.ts 1 34.09%
Totals Coverage Status
Change from base Build 5290924072: -0.001%
Covered Lines: 5178
Relevant Lines: 13291

💛 - Coveralls

@RichDom2185
Copy link
Member

Can I check what's left for this PR?

@RichDom2185 RichDom2185 added the blocked Something else needs pass review first label Jun 17, 2023
@RichDom2185 RichDom2185 marked this pull request as ready for review June 17, 2023 19:56
@RichDom2185
Copy link
Member

As per discussed offline, this PR is ready and simply blocked by awaiting the tests to be implemented in the corresponding backend PR: source-academy/backend#916.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll merge this first because we'll need some of the refactoring work you've done to implement SAML.

Thanks!

@RichDom2185 RichDom2185 merged commit 6ebe68e into master Nov 30, 2023
8 checks passed
@RichDom2185 RichDom2185 deleted the cas branch November 30, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something else needs pass review first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants