-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold device #50
Merged
Merged
Scaffold device #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
token is an optional string property of the new slice of the state, session. token represents an API token returned by the cadet backend. If there is no token, assume that the user is not logged in. token is a placeholder property.
I'm planning on also requiring log in to access the game. In that case, both device and game will call the log in dialog. Then, it makes more sense to connect state.session.token to log in once, rather than twice to device and game.
Added a variable to define images path as well.
remo5000
approved these changes
May 28, 2018
|
||
export const changeToken: ActionCreator<actionTypes.IAction> = (newToken: string) => ({ | ||
type: actionTypes.CHANGE_TOKEN, | ||
payload: newToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about the token being here, will make an issue. Seems good enough though
This was referenced May 28, 2018
Closed
Aulud
pushed a commit
to Aulud/cadet-frontend
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Issues fixed