Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold device #50

Merged
merged 8 commits into from
May 28, 2018
Merged

Scaffold device #50

merged 8 commits into from
May 28, 2018

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented May 28, 2018

Features

  • Rename dashboard as device
  • Add background to device, made its div extend fully to the rest of the page
  • Implement a log in dialog
  • Implement new slice of state, session
  • Implement dummy action and button to update session.token

Issues fixed

ning-y and others added 7 commits May 28, 2018 13:32
token is an optional string property of the new slice of the state, session.
token represents an API token returned by the cadet backend. If there is no
token, assume that the user is not logged in.

token is a placeholder property.
I'm planning on also requiring log in to access the game. In that case, both
device and game will call the log in dialog. Then, it makes more sense to
connect state.session.token to log in once, rather than twice to device and
game.
Added a variable to define images path as well.
@ning-y
Copy link
Member Author

ning-y commented May 28, 2018

(rebase d40c541 to ff28168 as 710d6a3 to 3b60d43 on 1c664e6)

@ning-y ning-y requested a review from remo5000 May 28, 2018 05:35

export const changeToken: ActionCreator<actionTypes.IAction> = (newToken: string) => ({
type: actionTypes.CHANGE_TOKEN,
payload: newToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the token being here, will make an issue. Seems good enough though

@remo5000 remo5000 merged commit 50d90c2 into master May 28, 2018
@ning-y ning-y deleted the scaffold-device branch May 28, 2018 05:56
This was referenced May 28, 2018
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants