Add wider bracketleft and bracketright glyphs (from alt-hack)

[vl4dimir]

@chrissimpkins Here you go sir. 🎩

@chrissimpkins edits below ---

TODO:

• review shapes in source
• review hints

[chrissimpkins]

👍 ty! will try to get to work on this sometime in the upcoming week. Finishing the open contour PR work and this will be next up

[chrissimpkins]

Getting started on this

[chrissimpkins]

These changes look fantastic Vladimir. I have been examining the shapes in various bodies of source across different idioms used. Examples incoming as I have them.

[chrissimpkins]

In C:

[chrissimpkins]

In Go:

[chrissimpkins]

In Python:

[chrissimpkins]

In Ruby:

[chrissimpkins]

In JavaScript:

[chrissimpkins]

I reviewed across sizes 8 - 14. We seem to be in good shape. Will have a look at the hinting this week and confirm that we don't need to do anything with the changes. I don't expect this to be the case. Let me know if you feel that we need any further modifications. If not and hints are ok, will merge to dev branch this week and we will plan to release this as part of the upcoming v3.003 changes. Nice work here Vladimir. This contribution is much appreciated.

[vl4dimir]

Thank you! 😄

I took a couple of screenshots on Windows (Visual Studio Code) since the rendering seems to be a bit different there:

The brackets look good IMHO. What I see as a potential future improvement are actually the parentheses, as they now look a bit subdued when compared to curly and square brackets. Here's an exaggerated example (I added a couple of random symbols to the C example):

The parentheses might use a bit more curvature, and perhaps a bit more vertical presence? For example, check out that lonely left parenthesis after hashcpy, it is a bit dominated by the brackets afterward. What do you think?

[chrissimpkins]

check out that lonely left parenthesis

😆 Yes, completely agree. There has been an open issue report for this for some time...

#120

I increased the spacing adjacent to the contents of the parentheses a couple of years ago but the curves and maybe even weight need to be addressed. If you have the time/interest, we're taking PR's ;)

Thanks for all of the additional images. I will review the changes on Windows and Linux as well. These shapes should not lead to hinting problems. I really like the appearance of the two glyphs immediately adjacent to each other with your changes.

Can you give me a one-liner of the design changes for the changelog? Increased length of top/bottom horizontal stroke and increased right sidebearing (and reduced left sidebearing) of left square bracket, vice versa for right square bracket spacing?

[vl4dimir]

Increased length of top/bottom horizontal stroke and increased right sidebearing (and reduced left sidebearing) of left square bracket, vice versa for right square bracket spacing?

Actually the sidebearings have been reduced symmetrically on both ends, making the glyphs remain centered but having wider horizontal strokes.

So how about: "Increased length of square brackets' horizontal strokes (symmetrically reducing left and right sidebearing)."

[chrissimpkins]

Perfect thanks

[chrissimpkins]

Here is the A/B diff on the shapes viewed on Windows:

Definitely a much better render. The vertical stroke seems to render more clearly for some reason. It appears much sharper on my monitor. Looks really good.

[chrissimpkins]

We're good here Vladimir. Merging to dev branch. This will be included in the v3.003 release. Thanks so much for these changes. These are high impact glyphs and the design change makes a big difference. 👍

[chrissimpkins]

Builds with these changes are available as of commit d7d629a on path build/ttf. No web font builds yet.

Versioned as Version 3.003;[19817712d]-dev

[chrissimpkins]

Windows users who would like to kick the tires with these changes can find builds named Hack Test in this installer:

https://github.com/source-foundry/Hack-Test-Win-Installer/releases/tag/v1.2.98

[vl4dimir]

@chrissimpkins Woohoo! Awesome! 😄🎉Thanks Chris!

[chrissimpkins]

Added to contributors list. Thanks again!