New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Inline Chat: Icons are missing #321

Closed

abeatrix opened this issue Jul 19, 2023 · 0 comments

Assignees

Labels

Contributor

abeatrix commented Jul 19, 2023

RE: https://sourcegraph.slack.com/archives/C05AGQYD528/p1689776744950469?thread_ts=1689681291.299019&cid=C05AGQYD528

The icons for Inline Chat and Inline Fixups are missing:

abeatrix self-assigned this

abeatrix added the clients/vscode label

abeatrix mentioned this issue

fix: missing icons for Inline Chat #320

Merged

abeatrix added a commit that referenced this issue


          fix: missing icons for Inline Chat (#320)

79f34b8

RE: #321

PR includes following minor changes:

- Fixed missing icons for inline chat. Issue was that we have moved the
output directory from `dist` to `dist/webview`, so we were not able to
get the correct icon path
- Update error message for Inline Touch RE
https://sourcegraph.slack.com/archives/C03CSAER9LK/p1689715497272569


## Test plan

<!--
All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles

Some examples:

// Just a doc change
none - docs change

// Unit tests got your back?
Unit tests

// Tested it manually and CI will also pitch in?
Manually tested and CI
-->

Inline Chat Before:

![Image](https://user-images.githubusercontent.com/68532117/254704544-35af4abf-9a04-487e-860b-04a4d3900bda.png)
![Screenshot 2023-07-19 at 8 20 39
AM](https://github.com/sourcegraph/cody/assets/68532117/dda01ca1-254b-4fc7-90a8-e74d0a5277e5)

Inline Chat After:

![image](https://github.com/sourcegraph/cody/assets/68532117/7af97b99-85bb-4867-a6cf-8495f8da8ec4)

![image](https://github.com/sourcegraph/cody/assets/68532117/bd4c68a1-6a01-48ce-8e0c-267d91ed2aad)

abeatrix closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment