Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code: remove sign-out menu #1032

Merged
merged 2 commits into from
Sep 13, 2023
Merged

VS Code: remove sign-out menu #1032

merged 2 commits into from
Sep 13, 2023

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Sep 13, 2023

Context

Test plan

Signed-out locally.

@valerybugakov valerybugakov enabled auto-merge (squash) September 13, 2023 07:29
@valerybugakov valerybugakov merged commit f99a245 into main Sep 13, 2023
8 checks passed
@valerybugakov valerybugakov deleted the vb/remove-sign-out-menu branch September 13, 2023 10:46
@toolmantim
Copy link
Contributor

Nice, thank you @valerybugakov!

We should remove signout from AuthMenuType too now it's unused, and rename the menu item from Sign Out... (the ... signifies it isn't immediate and has more steps) to Sign Out.

@valerybugakov
Copy link
Member Author

@toolmantim, good points! #1053 fixes them.

valerybugakov added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants