fix: use infillBlock not infillBlock.trimEnd() #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Hey @abeatrix, did you have a chance to look into this comment? I'm happy with this change, but I wonder what you think about the proposed simplification.
|
@valerybugakov Thanks for the review and for pointing me to the comments I overlooked! I've fixed the typo issue, and I'm going to work on adding the raw head proposal in a follow-up PR once i'm done with the caching issue since that has higher priority atm. Tysm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1063
Sorry was sick on Thursday and wasn't thinking straight 😅
This PR fixes my oversight in #1063.
The trim() logic should be added inside the replacement block, instead of trimming the whole infillBlock
Test plan
Test this change with the incomplete comment test case
Before
After.