change: register inline completion provider for files and notebooks only

[abeatrix]

Close #1112

The inline completion provider was previously registered for all languages ('*') at all places.

This change updates the registration to explicitly include notebook and text documents with file scheme to ensure autocompletion only works in places that we currently support.

Test plan

• Completions should work the same on saved text documents and notebook cells
• Completions should not work in source control input box or any other places that are not editor files / notebook files

Before

After

limited.to.file.scheme.and.notebook.mp4

[philipp-spiess]

Nice! But I think this regresses autocomplete on new unsaved files, did you try that?

[philipp-spiess]

#1120

[abeatrix]

@philipp-spiess I mentioned in the description that it would only work in saved text doc and notebook cells:

Completions should work the same on saved text documents and notebook cells

I thought the quality will not be good like in scm when working in an unsaved file because we won't be able to fetch relevant context for them / no language support so I didn't include that.

If that's something we want to continue support I can add the untitled scheme to the provider!

[abeatrix]

Saw you already did lol thanks!

[philipp-spiess]

Ohh gotcha... Yeah I added this on purpose because a user expected it since Copilot does it.

I guess what we can do is support it but only if a language id is specified (so we exclude plaintext which according to our analytics does also have a very bad acceptance rate)

[philipp-spiess]

Forget that I just tested and Copilot does not do this (anymore?) so I think your intuition is correct