Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent chat command selection from propagating event #1592

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Nov 1, 2023

fix: prevent chat command selection from propagating event

Prevent the up/down arrow key events from propagating when cycling through chat command suggestions. This stops the cursor within the input box from moving up to the front when selecting a suggestion.

Test plan

Before

Using arrow up in command selection box will move the cursor to the front

image

After

Moving up and down should not move the cursor position when the command selection box is showing. Cursor should stays in the back:

image

@abeatrix abeatrix requested review from kalanchan and a team November 1, 2023 21:47
@abeatrix abeatrix merged commit f2ebfc5 into main Nov 1, 2023
13 checks passed
@abeatrix abeatrix deleted the bee/fix-command-box branch November 1, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants