fix: race condition when opening chat panel #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1835
Edit
Updated to use debounce instead of auto-reload as it was causing most of the tests to fail.
Screen.Recording.2023-11-21.at.2.59.17.PM.mov
Old Summary
Instead of checking if the current chat panel is active or not, this PR updates the webview to reload automatically when it failed to load after 2000ms so users can have multiple chat panels opened, where some of them might be stuck at the loading stuck when it was first opened, but they will reload automatically.
Test plan
See 0.01 in video below:
Screen.Recording.2023-11-20.at.7.34.54.PM.mov
Works fine when starting multiple commands:
Screen.Recording.2023-11-20.at.7.43.17.PM.mov