-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display local context #1858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
I've only just spotted that snippets from ${n} files
UI language now… "snippets" isn't something we mention anywhere else and it would be good to avoid introducing it here.
Under what condition is that shown? (how does !file.range
occur?)
The intention was it would always say n
lines from y
files, so the user is able to get a sense of just how many lines were used/included in the context (so they can keep an eye on the volume of what's included)
Should I replace |
After thinking about it some more, I think "✨" should only display if "Enhanced Context" was checked too. |
cause not all of the sources use range or come from local files, but we can count them manually. We cannot generate them for old chat though so they will show up as ${n} file |
This test was verifying the user-selected files showed up in the context widget, but this was not intended (see first line of #1858). They were still showing up because the source was not passed through correctly. Now it is, they don't show.
As discussed with @toolmantim on slack (thread), the context display widget should also include local context except the ones added by the user manually via @
Test plan
Try running the
/test
command, which use local context only.BEFORE
Used local context is not showing up in the enhance context widget
AFTER
Used local context is included in the context widget