Chat: Improve enhanced context popover and button styles #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
commented
Dec 4, 2023
| @@ -198,7 +215,8 @@ export const EnhancedContextSettings: React.FunctionComponent<EnhancedContextSet | |||
| onClick={() => setOpen(!isOpen)} | |||
| title="Configure Enhanced Context" | |||
| > | |||
| <i className="codicon codicon-settings" /> | |||
| <i className="codicon codicon-sparkle" /> | |||
| {/* Show this dot if the popover has never been opened: <div className={styles.glowyDot}/> */} | |||
There was a problem hiding this comment.
Added this while I was here!
dominiccooney
approved these changes
Dec 4, 2023
| @@ -15,17 +15,19 @@ | |||
| } | |||
|
|
|||
| .enhanced-context-settings-popup label h1 { | |||
| text-transform: none; | |||
There was a problem hiding this comment.
THANK YOU FOR THIS. I GOT A BIT OF A SURPRISE WHEN OUR H1 STYLES CHANGED ELSEWHERE AND ENHANCED CONTEXT WAS SHOUTING ALL OF A SUDDEN. THE MAGIC OF CSS, RIGHT?
There was a problem hiding this comment.
lol I had the same feeling. Either that or someone decided IT NEEDS MORE POP!
|
@toolmantim I was doing some debugging and don't see your changes! I'm running Cody off tip of main, I don't see the sparkle icon :(
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the styles of the enhanced context popover and the button:
Test plan