-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: Remove App login #2099
vscode: Remove App login #2099
Conversation
cf4118f
to
52c6b46
Compare
Rather than try to solve for all auto-migration edge cases, could we have some sort of catch-all or fallback warning message that instructs the user to uninstall App and install Cody from scratch? This seems easier on both us and the user than trying to debug any errors that happen during migration. Nit: I notice you prefix your PR titles with "VScode:", which seems a bit off:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not gone through the test plan (see my previous message on whether a coarse-grained catch-all message could suffice here), but the code changes LGTM.
// messages can use local embeddings. We delay to this point so | ||
// local embeddings service start-up updating the context | ||
// provider does not cause autocompletes to disappear. | ||
void this.contextProvider.localEmbeddings?.start() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would local embeddings start-up interfere with autocomplete? Isn't it the case that autocomplete doesn't use embeddings?
Also: sidebar chat is going away, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would local embeddings start-up interfere with autocomplete? Isn't it the case that autocomplete doesn't use embeddings?
This is more to keep the tests green than a practical issue. But an autocomplete test failed with earlier initialization of local embeddings because:
- Starting local embeddings can be slow, if cody-engine is not downloaded. So we try to not start it.
- This means when we do actually start it, we need to tell the ContextProvider that the context may have changed.
- I assume autocomplete detects this context provider change and cancels its pending completion, which broke the test. I have not verified the callstack of that down to the ground though.
Also: sidebar chat is going away, right?
Sidebar chat is going away, in which case this code gets deleted. But if we shipped sidebar chat this week, I thought it would be nice to not break local embeddings for sidebar chat users for that week.
There's no messages to the user. They're either automatically logged in, or they land on the login screen. The test plan just tries to cover all the bases. |
61326b1
to
a404c93
Compare
This one is a doozy:
Leaves the LocalAppDetector so we can delete App/toast you to delete App soon.
Part of #1966.
Test plan
Setup
The big secret to testing this is recreating the "signed in to App" state, now that all the sign in options are gone. You do this by abusing the Enterprise sign-in options:
http://localhost:3080
which is App's URL.Next sign in
Signed into App, no dotcom token
Assuming you're still signed in to dotcom:
You should be dumped at the login pane.
Signed into App, cached invalid dotcom token