Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Style and UX improvements to the search panel #2138

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Search: Style and UX improvements to the search panel #2138

merged 4 commits into from
Dec 6, 2023

Conversation

toolmantim
Copy link
Contributor

A raft of small cleanups to the search UX:

  • Fix search input size to match VS Code
  • Make whole rows clickable
  • Fix pointer and text selection on rows
  • Add high contrast hover border
  • Add blank words as well as "No results"
  • Improve notification copy
  • Fix file icon vertical alignment
  • Fix truncation of long paths
Screen.Recording.2023-12-06.at.6.12.45.pm.mov

Test plan

  • Ran a search
  • Matched no results
  • Matched some results
  • Clicked rows
  • Hovered over truncated results

@toolmantim toolmantim requested review from beyang and a team December 6, 2023 07:15
@toolmantim toolmantim added this to the dec/chat-ux-improvements milestone Dec 6, 2023
dominiccooney
dominiccooney approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@toolmantim toolmantim merged commit 602f8bc into main Dec 6, 2023
13 checks passed
@toolmantim toolmantim deleted the tl/search-ux-tweaks branch December 6, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiccooney dominiccooney dominiccooney approved these changes

@beyang beyang Awaiting requested review from beyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
dec/chat-ux-improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@toolmantim @dominiccooney