Simple chat: Bring back chat telemetry #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
approved these changes
Dec 12, 2023
beyang
reviewed
Dec 12, 2023
beyang
reviewed
Dec 12, 2023
philipp-spiess
force-pushed
the
ps/fix-simple-chat-telemetry
branch
from
5bd4e7a
to
c01cf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back the
chat-question:executiedmetric for the new chat. I tried to recreate the metadata so it matches the old payloads. Anything we want to add? cc @chenkc805Test plan
Open the output console and trigger chat messages. Observe the event being logged