Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat Context: Provide relative path as current file #2344

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Chat Context: Provide relative path as current file #2344

merged 3 commits into from
Dec 13, 2023

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Dec 13, 2023

Description

The fileUri provided will be absolute. Instead, we always want to use a better Uri based on the relative file path that we already know.

closes #2331

Test plan

  1. Start chat, ask "what does this file do?"
  2. Check context
  3. Confirm current file is shown relative to users editor directory root.
  4. Confirm context is correctly used
  5. Confirm current file is clickable

@umpox umpox requested review from a team December 13, 2023 14:26
@umpox umpox enabled auto-merge (squash) December 13, 2023 15:19
philipp-spiess
philipp-spiess approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES YES YES

@umpox umpox merged commit ae3aae1 into main Dec 13, 2023
14 checks passed
@umpox umpox deleted the tr/home-file-absolute branch December 13, 2023 15:30
@toolmantim
Copy link
Contributor

This is great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: chat: current file context listed as absolute path and isn't clickable
3 participants
@umpox @toolmantim @philipp-spiess