Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of file paths in chat links #2398

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Dec 15, 2023

This fixes #2388, however the encoding format feels odd to me. I've opened microsoft/vscode#200965 to get some clarification about whether this is correct (and if so, hopefully it can be better documented).

fixed_links.mp4

@kalanchan

Test plan

  • Open a chat
  • Mention some files with @
  • Ensure clicking the filenames in the chat message correctly open the files (note: the filenames in the collapsed set are handled differently, the issue was specifically with the converted links in the chat message)
  • Also: verify the changes to tests for the new expected format are sensible and match what's discussed in command: links in markdown don't handle backslashes microsoft/vscode#200965 (at the time of writing there has been no response, so we may want to wait for one before merging this?)

This fixes #2388, however the encoding format feels odd to me. I've opened microsoft/vscode#200965 to get some clarification about whether this is correct (and if so, hopefully it can be better documented).
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@DanTup DanTup enabled auto-merge (squash) December 22, 2023 10:44
@DanTup DanTup merged commit bcd49b3 into main Dec 22, 2023
14 checks passed
@DanTup DanTup deleted the dantup/fix-encoding-of-chat-link-paths branch December 22, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: @-mentioning files on Windows shows markup instead of clickable links
2 participants