Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Add a new 16b exclusive experiment and document existing flags #2632

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

philipp-spiess
Copy link
Contributor

For https://docs.google.com/document/d/1P-Hb8BTbz-vMNFXw3gbAvphArsNvS1_8u4ID-phn8gI/edit, we are considereing moving all traffic to the 16b model. When we first run an experiment for this, the single-line CAR was better with the faster model. Part of this might be due to latency (which will improve with the ST deployment) but parts of this might also just no longer be relevant since we have made so many changes.

This PR adds a new client side feature flag that we can run in the short term to gather data on 16b exclusive setups. It will only have an affect if the user is already inside the CodyAutocompleteStarCoderHybrid experiment, which is currently our main StarCoder enablement flag.

Test plan

  • Be inside CodyAutocompleteStarCoderHybrid
  • Be inside CodyAutocompleteStarCoder16B
  • Observe that single-line completions use the 16b model identifier:
Screenshot 2024-01-09 at 11 46 51

@philipp-spiess philipp-spiess requested review from rafax and a team January 9, 2024 10:50
Copy link
Contributor

@rafax rafax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-authoritative LGTM :)

@@ -106,10 +106,13 @@ async function resolveDefaultProviderFromVSCodeConfigOrFeatureFlags(configuredPr
return { provider: configuredProvider }
}

const starCoderHybrid = await featureFlagProvider.evaluateFeatureFlag(FeatureFlag.CodyAutocompleteStarCoderHybrid)
const [starCoder, starCoder16B] = await Promise.all([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to keep starCoderHybrid here as a variable name for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sir

@philipp-spiess philipp-spiess merged commit 726733b into main Jan 9, 2024
15 checks passed
@philipp-spiess philipp-spiess deleted the ps/16b-exclusive-exp branch January 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants