Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symf index when stale #3261

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Update symf index when stale #3261

merged 5 commits into from
Feb 28, 2024

Conversation

beyang
Copy link
Member

@beyang beyang commented Feb 25, 2024

Local indexes are rebuilt automatically on a daily cadence when they are stale. Staleness is determined by checking whether files have changed across Git commits and in the set of working file updates not yet committed. If the indexed directories is not in a Git repository, then reindex every day.

Test plan

  • Test chat context still works
  • Change the update frequency from 1 day to 1 second and test that the index is rebuilt when files are changed and a new chat question is asked.

@beyang beyang marked this pull request as ready for review February 26, 2024 12:26
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@beyang beyang merged commit 4d6c1c9 into main Feb 28, 2024
18 of 20 checks passed
@beyang beyang deleted the bl/symf-index-update branch February 28, 2024 10:44
steveyegge pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants