Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tier status to event logger #3508

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Add tier status to event logger #3508

merged 7 commits into from
Mar 26, 2024

Conversation

philipp-spiess
Copy link
Contributor

@philipp-spiess philipp-spiess commented Mar 22, 2024

Closes #2466

@bobheadxi I need some help here getting this to work with the telemetry recorder too. How can I add default properties like the ones mentioned in #2466? 🤔 It looks like I can only overwrite the TelemetrySource and not add arbitrary default fields?

Test plan

Added some console.log debugging to help make sure this work

diff --git a/lib/shared/src/telemetry/EventLogger.ts b/lib/shared/src/telemetry/EventLogger.ts
index 82ad6e603..668699cc2 100644
--- a/lib/shared/src/telemetry/EventLogger.ts
+++ b/lib/shared/src/telemetry/EventLogger.ts
@@ -128,6 +128,9 @@ export class EventLogger {
             version: this.extensionDetails.version, // for backcompat
             hasV2Event,
         }
+        console.log('###############')
+        console.log(getTier(this.getAuthStatus()))
+        console.log('###############')
         this.gqlAPIClient
             .logEvent(
                 {
(END)

@philipp-spiess philipp-spiess changed the title Add auth status to event logger Add tier status to event logger Mar 22, 2024
@philipp-spiess
Copy link
Contributor Author

Screenshot 2024-03-25 at 12 53 27

Works with V2 too now, thanks @bobheadxi

@philipp-spiess philipp-spiess enabled auto-merge (squash) March 25, 2024 12:25
@philipp-spiess philipp-spiess merged commit 3016670 into main Mar 26, 2024
21 of 22 checks passed
@philipp-spiess philipp-spiess deleted the ps/log-tier-everywhere branch March 26, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log "tier" telemetry in all Cody VS Code events
2 participants