Edit: Default doc to Claude Haiku
#3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iirc we had this logic in the fix up controller that adds a new line at the end as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defaults the
doccommand to Claude 3 Haiku.I noticed that we were relying on this response always applying a new line for it to work correctly. This PR also addresses that by ensuring that all insertions end with a new line when finished.
I think this is the correct behaviour as we currently don't really have a strong use case for in-line insertions (rather that's where completions would come in anyway)
Test plan
doccommand works as expecteddoccommandgenerateandtestcloses #3517