Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Hide feedback button on err response #448

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Cody: Hide feedback button on err response #448

merged 5 commits into from
Aug 2, 2023

Conversation

deepak2431
Copy link
Contributor

@deepak2431 deepak2431 commented Jul 30, 2023

This PR closes #112.

Test plan

REC-20230731130528.mp4

@deepak2431 deepak2431 marked this pull request as draft July 30, 2023 08:18
@deepak2431 deepak2431 marked this pull request as ready for review July 31, 2023 07:37
@deepak2431
Copy link
Contributor Author

@philipp-spiess @toolmantim Can I have a review please?

@philipp-spiess philipp-spiess requested a review from a team August 1, 2023 11:07
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! I could swear I already reviewed this PR though, sorry for the long wait 😅

@philipp-spiess philipp-spiess merged commit e8317b2 into sourcegraph:main Aug 2, 2023
7 checks passed
@deepak2431
Copy link
Contributor Author

No problem @philipp-spiess, thanks for the review and merging it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Feedback Button on Error Response
2 participants