-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openctx: set query label if provided #4604
Conversation
bd1dd47
to
92f7177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Seeing it IRL I think the URL ones might need to say “Type or paste a URL…” because otherwise it feels like you paste them into the popover or something.
I still think it’s a mistake we don’t have “Search files…” and “Search symbols…” for the built-in files and symbols. Would be great to re-add imo.
Done
Will follow-up in another PR |
So just to confirm, you want to make these slightly different to OpenCtx? For OpenCtx this is the behaviour:
This is the current file behaviour:
The current behaviour kinda makes sense. Because we kinda insta-load symbols and files I'm not sure we need a prompt, but it would make sense from a consistency point of view. To help make this decision I greatly improved the cases in our story book. Check this PR out. #4624 |
This sets the query label to the newly added "label" field in OpenCtx. This is a field which prompts the user what to type in an at mention.
Test Plan: Tested manually the following cases
2024-06-19-openctx-label.mp4
Parent #4621
Fixes https://linear.app/sourcegraph/issue/CODY-2275/add-all-the-right-labels-for-provider-mentions-query-stats