Add metadata to context items #5153
Conversation
vscode/src/configuration.ts
Outdated
| @@ -135,6 +135,7 @@ export function getConfiguration( | |||
| */ | |||
|
|
|||
| internalUnstable: getHiddenSetting('internal.unstable', isTesting), | |||
| internalDebugContext: getHiddenSetting('internal.debugContext', false), | |||
There was a problem hiding this comment.
I wonder what we can do to make adding new settings easier. Something which doesn't require updating 3 different files.
There was a problem hiding this comment.
Yeah, tbh we should probably just use the vscode.workspace.getConfiguration api. What we've built around that feels like an unnecessary abstraction.
| @@ -244,6 +244,7 @@ export class ContextRetriever implements vscode.Disposable { | |||
| range, | |||
| source: ContextItemSource.Search, | |||
| content: text, | |||
| metadata: ['source:symf-live'], | |||
There was a problem hiding this comment.
Should we maybe add symf-live into the context source enum?
beyang
force-pushed
the
bl/symf-debugging
branch
from
e1c864a
to
c181479
Compare
Context items now include optional metadata about their source or scoring, which can help developers understand why certain items are appearing in the context. This change adds a `metadata` field to the `ContextItemCommon` interface and populates it for context items from Sourcegraph search, the local symbol index, and live search results.
beyang
force-pushed
the
bl/symf-debugging
branch
from
c181479
to
58f3968
Compare
"Enable Debug Mode" is technically user visible and I want to keep this internal for now (so as to not worry about the way it looks at all)
Not sure, I think that belongs in a separate change, as that alters how we want to convey to the end user what is happening. "This came from symf" feels like a low-level implementation detail, where as "came from search" maps to more of a user-level mental model. |
Context items now include optional metadata about their source or scoring, which can help developers understand why certain items are appearing in the context. This change adds a
metadatafield to theContextItemCommoninterface and populates it for context items from Sourcegraph search, the local symbol index, and live search results.You can view these by setting
"cody.internal.debug.context": truein settings. Thecody.internal.showContextAlternativeshas been removed and replaced by this one.Test plan
Test locally, doesn't affect prod.