feat: adopt eslint-plugin-unicorn #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
May 27, 2020
|
These ones will break CI so violations will be 0 😉 But once we have LSIF diagnostics I'll create an ESLint config for code smells specifically |
|
nice! let's get this running! 🚢 |
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to codify more of our best practices (because code review doesn't scale) I'd like to adopt this ruleset, which includes a whole bunch of awesome rules for best practices that we already strive to follow. Check out the docs for what's included and the rationale behind the rules: https://github.com/sindresorhus/eslint-plugin-unicorn
Almost all auto-fixable too 🔧