Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Improve org chart page #61

Closed
felixfbecker opened this issue Oct 1, 2021 · 8 comments
Closed

Improve org chart page #61

felixfbecker opened this issue Oct 1, 2021 · 8 comments
Assignees
Labels
🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook.

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Oct 1, 2021

We currently render the org chart by compiling all team pages' "Members" sections.

That is not a bad approach per se, but we do it all in the client at load time, which is noticeable and breaks often. For example, we currently seem to be adding a footer in the middle of the page, and date/time hover tooltips don't work in the dynamic content. The content can also not be searched I assume.

If we want to continue with this, we should look into doing this at build time. But also we should think about what the "ideal" org chart would look like for our handbook – perhaps data taken from the BambooHR API. Perhaps even a real chart (although those don't necessarily scale better, rather the opposite).

@felixfbecker felixfbecker added the 🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook. label Oct 1, 2021
@nicksnyder
Copy link
Contributor

I think we should solve this more generally and not over index on the org chart use case. Idea here: #649

@jyavorska
Copy link
Contributor

jyavorska commented Nov 8, 2021

You might be able to achieve this pretty simply by adding a manager field to team.yml. This is what https://gitlab.com/gitlab-com/www-gitlab-com/blob/9250f34a3902e7ba8b5f8e57ef5024b3ffd2056f/data/team.yml does (though with an added layer of indirection by having a role slug assigned to everyone.)

@marybelzer
Copy link
Contributor

Discovered a bug on this page: #818

@jyavorska
Copy link
Contributor

I implemented my idea above for the product team at #895. If we like it we could expand it to the whole company and replace this page.

@marybelzer
Copy link
Contributor

marybelzer commented Jan 24, 2022

Curious if we can close this due to the work done in #1763 , or if we need to explore further?

@felixfbecker
Copy link
Contributor Author

I haven't been following that work, but the org chart page still says "The org chart is generated automatically from team pages in the handbook (need to edit it?).". Is that wrong?

@jyavorska
Copy link
Contributor

I just updated the edit instructions via #1976, I think with that this can indeed be closed.

@marybelzer
Copy link
Contributor

thanks @jyavorska !

@katjuell katjuell self-assigned this Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook.
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants