Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds snapshot command to lsif-java cli #117

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Mar 8, 2021

Allows for emitting snapshots based on the semanticdb files, in the same style as our snapshot tests for a visual look at how files are being indexed.

Thanks @olafurpg for the Scala tutoring 🕺

@Strum355 Strum355 added this to the Code Intelligence Sprint 7 milestone Mar 8, 2021
@Strum355 Strum355 requested a review from olafurpg March 8, 2021 21:36
@Strum355 Strum355 self-assigned this Mar 8, 2021
Comment on lines +39 to +42
|public class Sample {
|// ^^^^^^ definition main/Sample#
|// ^^^^^^ definition main/Sample#`<init>`().
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill probably work on this next 😝 not quite right

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One minor suggestion, but feel free to merge

.gitignore Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@olafurpg
Copy link
Member

olafurpg commented Mar 9, 2021

You can fix the CI by running sbt fixAll

@Strum355 Strum355 merged commit c054f26 into main Mar 9, 2021
@Strum355 Strum355 deleted the nsc/snapshot-command branch March 9, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants